search

KIT-CMS / ntuple_processor

Submodule of ntuple-analysis containing the actual software to run the analysis
0 stars 3 forks source link

Simplify `tag` in `Friends` (aka remove `Friends`)? #22

Closed stwunsch closed 4 years ago

stwunsch commented 4 years ago

Could you explain what https://github.com/KIT-CMS/ntuple_processor/blob/master/utils/_booking.py#L53 is doing? Also, we do not use the tags at all, right?

In case I'm right, just remove the Friend class and just use the NTuple for it. There's no real need to sublcass it again. Then, you can also remove the NTupleBase and just use NTuple for everything.

stwunsch commented 4 years ago

We just agreed that we want an explicit tag of the friend in the NTuple constructor or give the NTuple a name so that we can still build the chains efficiently. Though move finding the name of the tag to dataset_from_artusoutput and no in the NTuple constructor.

maxgalli commented 4 years ago

Addressed as well in https://github.com/KIT-CMS/ntuple_processor/pull/31