search

KIT-HYD / bridget

Evapotranspiration toolbox
https://KIT-HYD.github.io/bridget
0 stars 0 forks source link

Update footprint.py #15

Closed AlexDo1 closed 3 years ago

AlexDo1 commented 3 years ago

Current state of the footprint function. Minor changes are likely to come in the next days, but it should be mostly finished.

mmaelicke commented 3 years ago

I see what you mean, but how do i implement this in the docstring?

time : list, datetime

In the description, you can state that it has to be a list of datetime objects, or just a datetime.

mmaelicke commented 3 years ago

@AlexDo1 I think you can go ahead and push (a) new commit(s) to footprint_StdPrj. Then I can review the changes. Anything that would still be open/left is then transferred into an issue. We will take care of the issues from January on then.

mmaelicke commented 3 years ago

I just ran into this error today while plotting some footprints.

Are you referring to the lastest changes of https://github.com/KIT-HYD/bridget/pull/15/commits/b4a2ce40fe5d9cb9b7f04baeacca9d809633702c ? So, did you fix the error? Then, request another review as soon as the code is finished. After approval, we can finally merge this branch

AlexDo1 commented 3 years ago

I fixed the error, yes. I thought I had commented directly on my commit.