KIT-IBG-5 / mdmcleaner

MDMcleaner the assessment, classification and refinement tool for microbial dark matter SAGs and MAGs
GNU General Public License v3.0
19 stars 6 forks source link

silva url #33

Closed aelbehery closed 2 years ago

aelbehery commented 2 years ago

Dear developer,

It seems that the url used for downloading silva "https://www.arb-silva.de/fileadmin/silva_databases/current" present in the "read_gtdb_taxonomy.py" Python script is no longer accessible,. I had to change it in the script to the ftp link: "ftp://arb-silva.de/current". Now, it's working as expected, but I thought it's useful to share this piece of info with you.

Best,

Ali

jvollme commented 2 years ago

hmm, that is weird. I just tested the url, and using wget i can still access it. And since mdmcleaner uses wget for downloads of reference data, this should work in mdmcleaner also...

could you provide a detailed error log, so i can better understand what is happening?

aelbehery commented 2 years ago

I didn't keep the log unfortunately, but basically it complained from the absence of VERSION.txt. It seems there has been something wrong with this url, but now when I used wget https://www.arb-silva.de/fileadmin/silva_databases/current/VERSION.txt and it worked with no problem. Anyway, the inclusion of the ftp link as a backup won't harm ig.

jvollme commented 2 years ago

Anyway, the inclusion of the ftp link as a backup won't harm ig.

That is true. I will add it as an second option whenever the other url fails. Will then be part of the next tagged release

aelbehery commented 2 years ago

Hello John,

Thanks. I have a question not related to this issue. I saw in your NAR article a comparison between bin contamination calculated by checkm vs that calculated by mdmcleaner, but when I used mdmcleaner clean command, I couldn't find the contamination % value. May I know where I can find it? Or if it's not available, how I can calculate it?

I really appreciate your help and cooperation.

Best regards,

Ali

On Wed, Aug 3, 2022, 2:06 PM JohnVollmers @.***> wrote:

Anyway, the inclusion of the ftp link as a backup won't harm ig.

That is true. I will add it as an second option whenever the other url fails. Will then be part of the next tagged release

— Reply to this email directly, view it on GitHub https://github.com/KIT-IBG-5/mdmcleaner/issues/33#issuecomment-1203862179, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACN4I2JCJ4NKY6UBTXL3LL3VXJOCXANCNFSM55IYSMFA . You are receiving this because you authored the thread.Message ID: @.***>

jvollme commented 2 years ago

hi, sorry the output tables are still a bit overcrowded and confusing. Contamination estimates from mdmcleaner are best indicated by the "fraction delete" column. Please note though, this gives the fraction of deleted contigs compared to the total contigs as a value between 0 and 1. So in order to get the percentage, you would have to multiply by 100. ALso any potential contaminations hidden in any unresolved "reference databse ambiguities" are not factored in there yet also.

I will simplify the result tables soon.

aelbehery commented 2 years ago

Thanks for your explanation.

On Thu, Aug 11, 2022, 11:00 PM JohnVollmers @.***> wrote:

hi, sorry the output tables are still a bit overcrowdd and confusing. Contamination estimates from mdmcleaner are best indicated by the "fraction delete" column. Please note though, this gives the fraction of deleted contigs compared to the total contigs as a value between 0 and 1. So in order to get the percentage, you would have to multiply by 100. ALso any potential contaminations hidden in any unresolved "reference databse ambiguities" are not factored in there yet also.

I will simplify the result tables soon.

— Reply to this email directly, view it on GitHub https://github.com/KIT-IBG-5/mdmcleaner/issues/33#issuecomment-1212487347, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACN4I2K65QDTFWAFNXTV5KDVYVSWRANCNFSM55IYSMFA . You are receiving this because you authored the thread.Message ID: @.***>