search

KIT-MRT / mrt_cmake_modules

Automated catkin project handling framework
BSD 3-Clause "New" or "Revised" License
41 stars 24 forks source link

fix action build #23

Closed BaltashovIlia closed 3 years ago

BaltashovIlia commented 3 years ago

Hi,

according to this MR add_action_files does not support absolute paths.

So, if I build a package containing an action file using mrt_cmake_modules, I will get an error like this:

Errors << camera_control_msgs:cmake /home/user/mrt_update_ws/logs/camera_control_msgs/build.cmake.000.log
CMake Error at /opt/ros/noetic/share/actionlib_msgs/cmake/actionlib_msgs-extras.cmake:20 (message): add_action_files() directory not found: /home/user/mrt_update_ws/src/camera_control_msgs//home/user/mrt_update_ws/src/camera_control_msgs/action Call Stack (most recent call first): /home/user/mrt_update_ws/src/mrt_cmake_modules/cmake/mrt_cmake_modules-macros.cmake:431 (add_action_files) CMakeLists.txt:48 (mrt_add_action_files)

To reproduce the build error you can use this package: https://github.com/BaltashovIlia/camera_control_msgs

BaltashovIlia commented 3 years ago

I will additionally try to fix add_action_files, but for better compatibility with older ROS versions I think it is worth using a relative path here.

poggenhans commented 3 years ago

Thanks! We merged that with efde1cf4202e0c54e6e59485469d51c27e186dd8 (github does not recognize merging via rebase)