KITPraktomatTeam / Praktomat

quality control for programming assignments
http://pp.ipd.kit.edu/projects/praktomat/praktomat.php
GNU General Public License v2.0
46 stars 22 forks source link

praktomat.policy vs java.policy #307

Open chris21k opened 4 years ago

chris21k commented 4 years ago

Praktomat/src/checker/checker/DejaGnu.py line 120 references not existing file "praktomat.policy" instead of in directory Praktomat/src/checker/scripts/ supplied "java.policy". Thus, 'spawn java' starts a jvm with empty policies via Praktomat/src/checker/scripts/java. A workaround without touching the python code is $ ln -s java.policy praktomat.policy in this directory.

ifrh commented 3 years ago

Just found on https://docs.oracle.com/en/java/javase/17/security/java-security-overview1.html#GUID-BBEC2DC8-BA00-42B1-B52A-A49488FCF8FE

The Security Manager and APIs related to it have been deprecated and are subject to removal in a future release. There is no replacement for the Security Manager. See JEP 411 - https://openjdk.java.net/jeps/411 - for discussion and alternatives.

corresponding information here: https://bugs.openjdk.java.net/browse/JDK-8264713

ifrh commented 2 years ago

@chris21k could you please update the issue headline, that one can read, that Security Manager is deprecated?

referencing to an old mail to praktomat mailinglist (8.10.2016 of @nomeata ), perhaps firejail https://firejail.wordpress.com/ could use as sandbox i.e. on systems where Docker containers are "too big".

ifrh commented 2 years ago

Implementation changed to https://github.com/KITPraktomatTeam/Praktomat/blob/92d1cf50157426e7aa3cd20e665bfb31ffe2f25a/src/checker/checker/DejaGnu.py#L122 via commit https://github.com/KITPraktomatTeam/Praktomat/commit/bc585cf9e52af6c18f55208e7463c30dd0d81c06#diff-e64c26e50d196ca3f4cccef7ec36c569a692481cafc1b02a789b44f321e7e590 merged to master