search

KITrobotics / iirob_filters

Implementation of some usefull filters used in ROS
Apache License 2.0
12 stars 14 forks source link

LowPassFilter not follow pluglib interface #11

Open jacknlliu opened 6 years ago

jacknlliu commented 6 years ago

LowPassFilter implement did not follow the pluglib interface in which a constructor without parameters is required for classes. But here LowPassFilter has its parameters

LowPassFilter(double sampling_frequency = 0.0, double damping_frequency = 0.0, double damping_intensity = 0.0, double divider = 0.0);

And the LowPassFilter interface still works? It can't find in filters_plugin.xml.

destogl commented 6 years ago

Thank you for your comment. Yes there are some issues because we are currently in complete rewriting the filters.

Hopefully everything will be corrected soon.

jacknlliu commented 6 years ago

Thanks for your reply. Hopefully, it works correctly soon. :thumbsup:

destogl commented 4 years ago

@jacknlliu is this still relevant for you?