Clear PLOT_ENABLED or DRAW_ENABLED flags when closing Plots or Radiat…

[neoklis]

…ion windows

[KJ7LNW]

It looks like DRAW_QUIT and PLOT_QUIT are set but never cleared.

Should they ever be cleared, like if the user clicks "Cancel" ?

[KJ7LNW]

Hi Neoklis, thanks for the update!

There are a couple of issues to fix before we can merge:

1. For the Coverity patches, please update the description to include the Coverity issue being addressed:
   • We want one commit per Coverity patch, with the relevant Coverity message in that single commit.
   • The goal with git is one commit per fix or feature, with a great description for each commit. Here is a good article on Submitting patches: the essential guide to getting your code into the kernel that does a good job describing commit practices with git.
   • This can be fixed by splitting the commit into multiple commits. See the article on How to split an earlier git commit into multiple ones
2. The entire measurements.c file uses tabs instead of spaces because we want all new code to follow Linux kernel coding style guidelines which standardizes interactions between developers:
   • The changes to measurements.c use 2x-spaces for indentation which are not only visually confusing for those who use 8-char tab stops, but it can cause merge conflicts when two people collaborate on the same file. There are (at least) two different indentation styles in the xnec2c code. For now please follow whatever indentation exists in the neighboring text:
     • Some places use tabs
     • Some places use 2x spaces
     • (I would like to fix them with indent for consistent formatting, but not yet because I don't want to break other developer merges and there is at least one other developer with a big xnec2c pull request pending.)
   • You can see the issue visually here on github's diff browser where the new if doesn't line up to the else.
   • I'm guessing your tabs are set to render as 2-spaces but your editor is creating spaces instead of tabs so you might not notice. In this particular case, since the neighboring text uses tabs, please use a single tab character instead of spaces so other developers can set whatever indentation they like in their editor.
   • If you use vim then this is probably what you want: set tabstop=2 softtabstop=0 noexpandtab shiftwidth=2. See this article for more detail.
   • This can be fixed, by using git rebase -i HEAD~10 to re-order commits, reword messages, and squash them to the previous commit (like to merge the two FLAG commits). See this article: The life-changing magic of git rebase -i

Note that after doing a rebase you have to use --force to push your changes:

git push github master --force

-Eric

[neoklis]

Hi Neoklis, thanks for the update!

There are a couple of issues to fix before we can merge: OK, looks like I have some reading to do. Teaching an old dog new tricks ....

-- Best Regards

Neoklis - Ham Radio Call: 5B4AZ http://www.5b4az.org/ https://www.qsl.net/5b4az/index.html