search

KJ7LNW / xnec2c

Xnec2c is a high-performance multi-threaded electromagnetic simulation package to model antenna near- and far-field radiation patterns for Linux and UNIX operating systems.
https://www.xnec2c.org/
GNU General Public License v3.0
77 stars 16 forks source link

Drawing of triangular surface patches #32

Closed charlieb closed 5 months ago

charlieb commented 1 year ago

The drawing routine for surface patches is only good for rectangular patches and makes triangular patches look really weird and wrong. I'm actually not sure if the underlying nec2 engine handles triangular patches but if it does, I'd be happy to submit a pull request for better drawing of triangular patches.

KJ7LNW commented 1 year ago

Thank you for offering!

Of course patches are welcome. Beware, that code is a bit messy: Refactoring for OpenGL might actually be easier than fixing the old code. If you're interested in fixing the patch rendering, first please review #23 (OpenGL Support).

If you want to fix existing rendering then go for it, but it is slow software line rendering that redraws every frame and OpenGL really would be best since there is an existing branch with alpha support.

KJ7LNW commented 5 months ago

Hi @charlieb, would still gladly accept a triangle drawing PR if you're up to it. If so, then please re-open this issue or post a PR.