KLayout / klayout

KLayout Main Sources
http://www.klayout.org
GNU General Public License v3.0
764 stars 199 forks source link

Spice throws error at midline semicolon comments #1784

Closed Br1tt21 closed 2 weeks ago

Br1tt21 commented 1 month ago

In the same fashion as #1681, some spice dialects use semicolon to accept a comment mid line, like this: .param sky130_fd_pr__nfet_05v0_nvt__vth0_slope=0.0012 ; All devices This currently throws error RuntimeError: Expected a word string here: ; Could this be implemented in KLayout's spice reader?

klayoutmatthias commented 1 month ago

It can, but you won't get it that cheaply :)

There are other observations about netlist features, and a code sweep deserves more than a trivial patch.

Here are some:

what else?

Matthias

Br1tt21 commented 1 month ago

Wish I could add more, but this was the only thing I ran into. Just working with this for my internship project, so I'm not all that experienced.

On a semi-related note though, with this project I had trouble getting the LVS to run due to a coupling component (NGSpice manual 3.3.12). Ended up removing it because it didn't matter for the layout, but it's part of a model so that's not really ideal. I couldn't make an issue on that repository so I thought I'd drop it here.

Anyway if I find anything related to this point, I'll add it!

klayoutmatthias commented 1 month ago

I see :)

No problem. Let me just wait a little and collect some more issues, if possible.

Thanks and best regards,

Matthias

klayoutmatthias commented 2 weeks ago

Should not be an issue any longer with 0.29.5