KMFDManic / NESC-SNESC-Modifications

All of your NES-SNES-Playstation Classic Modification Needs!
GNU Lesser General Public License v3.0
273 stars 33 forks source link

Nestopia not saving for FDS games #89

Closed MushGuyDS closed 6 years ago

MushGuyDS commented 6 years ago

Hello, I remember this was an issue back in retroarch-clover ( https://github.com/ClusterM/retroarch-clover/issues/23 ), and after playing and trying to save in Yume Koujou Doki Doki Panic, it seems that this is still an issue with this version of Retroarch (_km_retroarch_171_xtreme_2_26_18, using Nestopia). In case you're asking, I'm using Hakchi2 CE 1.1.0. Am I doing something wrong? I think it's supposed to save after clearing a world, or at least a stage. It is it because the ROM is in a .7z file?

KMFDManic commented 6 years ago

Try saving with either ffmpeg variant of RetroArch in my set. And, let me know.

MushGuyDS commented 6 years ago

OK, I tried it, and nope, still no save.

KMFDManic commented 6 years ago

How many games per folder and have you tried it on a known to save game, such as Zelda, and/or used a suspend state? Try with fceumm, by chance? Your command line for the game?

MushGuyDS commented 6 years ago

OK, this is what I found: I have 36 games in the NES folder, three of which are FDS games, all loaded using bin/nestopia (using bin/nes instead defaults me to fceumm for some reason). I tried saving in Zelda with Nestopia, but it gives me no save. I tried with fceumm, and still no save. Here are the command lines I used:

/bin/nestopia /var/games/CLV-I-IXMSL/Yume_Koujou_Doki_Doki_PanicJapan.fds.7z /bin/nes /var/games/CLV-I-IXMSL/Yume_Koujou_Doki_Doki_PanicJapan.fds.7z /bin/nestopia /var/games/CLV-I-ZZSQC/Zelda_no_Densetsu_The_Hyrule_Fantasy_Japanv1.1.fds.7z /bin/nes /var/games/CLV-I-ZZSQC/Zelda_no_Densetsu_The_Hyrule_Fantasy_Japanv1.1.fds.7z

Save states do work, however, but savegames don't.

KMFDManic commented 6 years ago

USB-HOST, or Non?

MushGuyDS commented 6 years ago

Using USB-HOST. Saving works for the other games I have (SNES, NES, Genesis), but not for FDS.

KMFDManic commented 6 years ago

You using a /hakchi/saves folder? And, since you are on CE, try this with non-USB, too.

MushGuyDS commented 6 years ago

OK, already tried with non-USB. Still no save.

KMFDManic commented 6 years ago

I will try testing it, personally, tomorrow. Thanks for the test results.

KMFDManic commented 6 years ago

For the record, the coding points to .fds as extension. Back then, when it was implemented as a fix, NES/FDS Games, as compressed games, was not an option. The coding is all intact, and the fix is there. I didn't test it, yet. But, basically, it looks for Nestopia as the Core, and FDS as the extension. So, if you get to it before me, try it "uncompressed" with Nestopia:) Most must be so reliant on Suspend States, they have not realized this:) Good catch. I will try to test it, myself, too:) Being FDS takes up so little space, if it still works properly, uncompressed is not so bad:)

KMFDManic commented 6 years ago

If you have further tested this any, please let me know. I know it is not exactly high priority. But, it would be nice to fix it, if at all possible. The original coding was for uncompressed FDS Games running on NESC. Most are running on SNESC, now, with compressed Games:) Keep me posted. I will close the issue for now, but will still follow your responses as well as keep it on my agenda of things to hopefully be able to fix!