search

KMKfw / kmk_firmware

Clackety Keyboards Powered by Python
https://kmkfw.zulipchat.com
Other
1.45k stars 486 forks source link

Fix dependency of TapDance on instantiated HoldTap #1027

Closed xs5871 closed 2 months ago

xs5871 commented 2 months ago

1010

claycooper commented 2 months ago

I see #1010 mentioned documentation. Do any changes need to happen there? Did you look or do you want me to?

xs5871 commented 2 months ago

No changes to the documentation are necessary. TapDance can now be used without HoldTap.

JamesToBoot commented 2 months ago

👍

JamesToBoot commented 2 months ago

Hey @xs5871 if you have a sec, can you briefly explain why the removal of the import KC and the changing of KC.HT to its own veriable/name (not sure what you would call that) removes TD dependancy on the HT?

It is not obvious to me where the dependancy was.

xs5871 commented 2 months ago

KC.HT is basically an alias for HoldTapKey that has been registered under the name "HT" in the keycode dictionary "KC" -- for convenient usage in keymaps. That alias is created during instantiation of HoldTap -> that was the dependency. But TapDance doesn't have to use that alias, it can use the "original".