search

KMKfw / kmk_firmware

Clackety Keyboards Powered by Python
https://kmkfw.zulipchat.com
Other
1.42k stars 480 forks source link

Lily58 patches #778

Closed hjw closed 1 year ago

hjw commented 1 year ago

There are a few glaring problems in the lily58 related files included in the repository. The coord_mapping was wrong and the example keyboard.keymaps had errors, both in the default(boards) folder as well as the user_keymaps folder.

I fixed the files in the boards folder... at least as far as the maps were concerned and I added warning comments to the user contributed files.

xs5871 commented 1 year ago

When I look at that picture of a lily58, I don't see 5 keys in the bottom row.

hjw commented 1 year ago

The key which you are seeing, that looks like it's on row 3 or 4 is actually wired on row 5.

qmk's keyboard/keycap files show that key on row four but that is because they must map it to the correct row/column in another config file.

I use a lily58. Ran it with qmk and pro micro's for a couple of years and switched to kmk with kb2040s in November 2022.

xs5871 commented 1 year ago

Sorry for the late response. The layout of the keymap is supposed to be representative of the visual layout of the keyboard, not necessarily the electrical. In turn, the "old" keymap would be the preferred way and the coord_mapping needs adjusting to reflect that.

hjw commented 1 year ago

ok. i will fix the mapping so that it works with a visually correct keymap and also look for someplace in the docs/wiki to note that this is how it should be done. (The release mapping does not work properly with the visually correct keymap)