KMKfw / kmk_firmware

Clackety Keyboards Powered by Python
https://kmkfw.zulipchat.com
Other
1.33k stars 460 forks source link

Add Pico quickpin #855

Closed Allstreamer closed 1 month ago

Allstreamer commented 10 months ago

Create Raspberry PI pico quickpin based on the Pico Docs. (Also tested on Pico H)

Allstreamer commented 10 months ago

Not sure what would be the best structure. Right now it's compatible with both the pico H & pico W so i was thinking of naming it pico but that would make the import:

from kmk.quickpins.pico.pico import pinout

which feels a bit weird, i'm thinking of making it top level or making a raspberry pi folder? IDK not sure if i should just keep the name as pico.

For Refrence:

# Pico folder
from kmk.quickpin.pico.pico import pinout

# Top Level
from kmk.quickpin.pico import pinout

# Raspi folder
from kmk.quickpin.raspi.pico import pinout
# or
from kmk.quickpin.raspberry.pico import pinout
# or 
from kmk.quickpin.raspberrypi.pico import pinout
xs5871 commented 10 months ago

Of course it looks weird. quickpin is meant to translate physical pin names / mappings from different board layouts. You're translating from the pi pico to the pi pico, which is kind of pointless imo... but if you think that's a good addition, then kmk.quickpin.pico.pico it is.

kdb424 commented 9 months ago

I've seen some pico clones, but AFIK, I haven't seen any that change the pinout's to the point of having a use for quickpin. The only use I can see for this is not having to find the pinout with an image for people reading the code, but it wouldn't have the intended primary use of quickpin.

xs5871 commented 1 month ago

I'll close this as stale.