search

KMKfw / kmk_firmware

Clackety Keyboards Powered by Python
https://kmkfw.zulipchat.com
Other
1.33k stars 460 forks source link

feat: Only build mpy files when kmk library files changed #857

Closed grasegger closed 10 months ago

grasegger commented 10 months ago

close #818

grasegger commented 10 months ago

I am very confused by the tests failing ...

Also I was not sure about using an include or exclude, since I am not sure what files are needed for building I started with an exclude

grasegger commented 10 months ago

Running make test locally "just works", can I get feedback about the nature of the fail? I am not deep into python and the error does not make immediate sense to me.

xs5871 commented 10 months ago

Many of our unit tests are dependent on timing and timeouts. Occasionally and somewhat randomly, some tests fail to meet their race conditions. Re-running the tests is the "fix".

grasegger commented 10 months ago

@xs5871 if we're going with an Allowlist I would suggest to include the make- and pipfiles, otherwise one could push build-breaking changes that would only fail once KMK changes again.

xs5871 commented 10 months ago

I don't understand. Neither Makefile nor Pipfile are involved in the mpy compliation process.

grasegger commented 10 months ago

Then ignore my comment, sorry 🙈