KMKfw / kmk_firmware

Clackety Keyboards Powered by Python
https://kmkfw.zulipchat.com
Other
1.33k stars 460 forks source link

[BUG] Invalid key for Locking Caps Lock, Num Lock, Scroll Lock #867

Closed synwt closed 6 months ago

synwt commented 10 months ago

1097430 kmk.keys: Invalid key: LOCKING_CAPS 1097437 kmk.keys: Invalid key: LOCKING_NUM 1097444 kmk.keys: Invalid key: LOCKING_SCROLL

JeffreyStocker commented 10 months ago

Taking a quick glance at the code, I'm seeing part of it commented out with the comment " # FIXME: Investigate whether this key actually works, and

uncomment when/if it does."

https://github.com/KMKfw/kmk_firmware/blob/80e10d30cf147ddc14eda045d34d4253c2deec75/kmk/keys.py#L214 https://github.com/KMKfw/kmk_firmware/blob/80e10d30cf147ddc14eda045d34d4253c2deec75/kmk/keys.py#L416

Unless you need one of those to be locking (which I do not know what locking does off the top of my head), try

claycooper commented 6 months ago

Closing as stale.