KMKfw / kmk_firmware

Clackety Keyboards Powered by Python
https://kmkfw.zulipchat.com
Other
1.45k stars 485 forks source link

Add fruitbar-R2 board. #868

Open newts opened 1 year ago

newts commented 1 year ago

Port of KMK to the fruitbar R2 40% Keyboard with OLED. (the fruitbar has a rotary encoder option which I don't have on mine and did not include here yet).

https://p3dstore.com/products/fruitbar-budget-skeleton-case-and-pcb-group-buy

xs5871 commented 1 year ago

There're couple of things the linter isn't happy about.

newts commented 1 year ago

I see. I will fix. can I run the lint on my own? it is just pylint?

xs5871 commented 1 year ago

There's a make command for that: https://github.com/KMKfw/kmk_firmware/blob/master/docs/en/contributing.md#code-style

newts commented 1 year ago

I ran black on my files and updated my master. I am not familiar with github pulls if there is more to do. I could not get the test to run on my system (ubuntu).

xs5871 commented 1 year ago

I ran black on my files and updated my master. I am not familiar with github pulls if there is more to do. I could not get the test to run on my system (ubuntu).

make devdeps
make test
newts commented 1 year ago

Ok I figured how to run the tests locally and fixed the pylint errors.

jv@Balsamo:~/proj/keebs/fruity-oaty-bar$ make test
.........................................................................
----------------------------------------------------------------------
Ran 73 tests in 4.646s

OK