KMKfw / kmk_firmware

Clackety Keyboards Powered by Python
https://kmkfw.zulipchat.com
Other
1.33k stars 460 forks source link

use disable_auto_write with complex animations #885

Closed JeffreyStocker closed 9 months ago

JeffreyStocker commented 9 months ago

Minor increase in RGB efficiency by preventing the more complex animations from updating the LEDs twice. Once in increase_hue and again in set_hsv or set_hsv_fill

xs5871 commented 9 months ago

increase_hue doesn't update the pixel buffer.

xs5871 commented 9 months ago

In addition: I was thinking about removing disable_auto_update altogether (#890).

JeffreyStocker commented 9 months ago

yea that works. I'm just going to close this out then