KMKfw / kmk_firmware

Clackety Keyboards Powered by Python
https://kmkfw.zulipchat.com
Other
1.45k stars 486 forks source link

[BUG] RGB_TOG is not powering down RGB #904

Closed Xoffio closed 1 year ago

Xoffio commented 1 year ago

Describe the bug I am using the latest KMK at the moment and it looks like the RGB_TOG got broken at some point. Any animation like KC.RGB_MODE_RAINBOW or KC.RGB_MODE_KNIGHT works properly. I can even power down rgb by pressing KC.RGB_VAD multiple times.

if i press RGB_TOG nothing happens. If i have an animation like the knight effect then the animation stops when pressed toggle, and continues once i press the rgb toggle again.

To Reproduce Tested on a spitted keyboard Steps to reproduce the behavior:

Expected behavior KC.RGB_TOG should power off the board's rgb. if there is any other animation running, it should turn off the rgb instead of pausing the animation

Note I think I know why this is happening and i have a peace of code that might fix it.