search

KMKfw / kmk_firmware

Clackety Keyboards Powered by Python
https://kmkfw.zulipchat.com
Other
1.32k stars 458 forks source link

Mapping for nullbits tidbit board with bit-c pro #916

Closed patricksurry closed 7 months ago

patricksurry commented 7 months ago

Split from https://github.com/KMKfw/kmk_firmware/pull/915 after review by board owner. cc @jaygreco

patricksurry commented 7 months ago

the contribution guidelines lint make fix-isort fix-formatting test makes changes to a bunch of other files I haven't touched. but it also doesn't seem to match GHA which complained about double-quoted doc string after lint passes?

I can add the lint changes to the other files here if that's helpful, just lmk

xs5871 commented 7 months ago

GHA runs make lint for linting. The fix-* targets are for mostly automatic fixing of lint errors and are meant to be run manually before a commit. The lint and fix targets run different tools and have slightly different code coverage for some historical reason... There can sometimes be differences, this time it's something on your side though. Maybe your master branch or your tooling is out of date.