Minor tweaks to the example in the Display extension doc

KMKfw / kmk_firmware

Clackety Keyboards Powered by Python

https://kmkfw.zulipchat.com

Other

1.32k stars 458 forks source link

Minor tweaks to the example in the Display extension doc #926

Closed brianmarco closed 6 months ago

brianmarco commented 6 months ago

A few tweaks to the example mentioned in the Display extension documentation.

Moved the device_address argument from the Display instantiation to the SSD1306 instantiation. Display doesn't currently support this argument, but SSD1306 does (https://github.com/KMKfw/kmk_firmware/blob/master/kmk/extensions/display.py#L137)
Added missing comma to the arguments for the Display instantiation.

brianmarco commented 6 months ago

Thanks for the review @xs5871 . I applied your feedback as suggested. I also applied the same feedback to the width argument for Display, and adjusted the dim_target argument to make it different from the default.