Remove the `peg_oled_display` extension

KMKfw / kmk_firmware

Clackety Keyboards Powered by Python

https://kmkfw.zulipchat.com

Other

1.32k stars 458 forks source link

Remove the `peg_oled_display` extension #977

Closed xs5871 closed 3 weeks ago

xs5871 commented 3 weeks ago

Reasons for the removal:

terrible performance
poor code quality
unmaintained / unsupported

Where applicable: replace with the officially supported display extension.

claycooper commented 3 weeks ago

Thank you.

regicidalplutophage commented 3 weeks ago

I'm not against removing it, but maybe we should come up with an example that's basically the re-implementation of PEG OLED to use in affected boards.

xs5871 commented 3 weeks ago

All boards in our repository that used it are "ported" as part of the commit. To the best of my ability at least; they only displayed the top most layer anyway.

regicidalplutophage commented 3 weeks ago

they only displayed the top most layer anyway

I missed that detail about them.

LGTM!