KMKfw / kmk_firmware

Clackety Keyboards Powered by Python
https://kmkfw.zulipchat.com
Other
1.32k stars 458 forks source link

Remove key pre/post handlers in favor of macros #980

Closed xs5871 closed 3 weeks ago

xs5871 commented 3 weeks ago

I have only once seen a legitimate use case for these handlers -- one where custom handlers would've been a bit more complicated, and that use case was so niche that I can't remember what it was. I don't think this functionality and the associated overhead should be the default for every single key. Also: macros can replace this functionality without requiring users to learn how to make custom keys from scratch.

xs5871 commented 3 weeks ago

At least the always topical shrek will be preserved for posterity in user_keymaps/.