Open TRSx80 opened 4 years ago
Hi @KMahoney,
I am still pretty new to Emacs theming, but something that occurred to me while working on this was that perhaps the better approach would be to change kpm-list
to use the "default alias" (for lack of a better term, I don't know what they are really called [1] ) font face names in Emacs, instead of separate hard coded ones. But perhaps you have some reasoning behind your choices that I am unaware of?
I only changed themes a couple times in the last few years, but kpm-list
(unlike most other packages) always seemed to stick out with it's own color scheme, instead of picking up the one I had overall set for Emacs.
Since @arcticicestudio got back to me in the thread I made over there at Nord theme, I suppose I might be circling back to this at some point (and perhaps eventually submitting a PR into Nord, etc.). So I wanted to ping you and get your thoughts on this.
[1] I am talking about the ones that are named like:
font-lock-keyword-face
font-lock-string-face
etc.
Or, in case of directory font, we could use the default:
dired-directory
font-lock face. And then maybe re-map some of the others to appropriate kpm-list
faces.
If you didn't know already, you can see all of these (and more, in fact all faces I think) by doing M-x list-faces-display
.
I think this would be a more general solution, which would not only work well for Nord, but any other user chosen theme as well.
What do you think?
Hallo,
First off, thanks for sharing this, it's really useful! I use it all the time for a couple years now, I don't know what I would do without it! :beers:
I was on Solarized Dark for a long time, then recently stumbled across (and switched to) Nord theme which I really like! Nord supports just about everything I need (Emacs, terminal, GTK, etc.) in a nice and consistent way, but there was one thing standing out, and that quite glaringly... :smile: Well, in relation to how Nord looks, anyway.
Now I am no Emacs theming expert to be sure, and certainly no artist, but the palette and guidelines are pretty easy to follow (Nord creator deserves most the credit for picking (what are IMHO) really great color combos), and so tonight I spent a little time and came up with something I thought was workable:
Again, I am not even sure I did this "properly" (any Emacs theming tips are welcomed!) but I got it to work by putting the following in my Emacs init to override the defaults.
It's not too much trouble for me to share it here now, in the same spirit that I found this software was shared with me, on the off chance someone else happens along with same requirements (how small do you think is the Venn diagram union between
kpm-list
and Nord theme users anyway?). :smile:Of course you can set the colors directly by hex value, but I find this way of aliasing them easier to work with. Especially when "playing around" and tweaking things. Just make sure you assign the color palette variables (
nord0...16
) earlier on in the init loading then when you need to use them (in case you end up using them in multiple places to override other things as well, like I do).And so, without further ado:
Cheers! :beers: