search

KNowledgeOnWebScale / solid-authentication-browser-extension

10 stars 1 forks source link

add domain filter option #28

Closed axellorreyne closed 1 year ago

axellorreyne commented 1 year ago

This fixes #24

pheyvaer commented 1 year ago

@axellorreyne Can you first fix the conflicts before I review? Thanks!

axellorreyne commented 1 year ago

@axellorreyne Can you first fix the conflicts before I review? Thanks!

Conflicts resolved in 4f06fb07bf0e7e9e0e1ccbc2e12869f8b5be1515

axellorreyne commented 1 year ago

After logging in without domain filter and I open the pop up again I get this error: image

This is caused by a bug (#31) on main, which was merged into this branch after resolving the aforementioned conflict. This issue has been fixed in #32 which was merged into main after the conflict resolution on this branch.

pheyvaer commented 1 year ago

Great! Can you merge main in this branch as well?

axellorreyne commented 1 year ago

Great! Can you merge main in this branch as well?

merged in ae860bc6724b8b80dd9fe1000a402dd18805dcd0