search

KNowledgeOnWebScale / solid-authentication-browser-extension

10 stars 1 forks source link

Add code documentation to new extension #46

Open rafael-mindreau opened 1 year ago

rafael-mindreau commented 1 year ago

Please comment on parts that are still not clear or need more clarification.

pheyvaer commented 1 year ago

I fails to show the login widget in the showcase for me. I see in the console 10.000s of messages that say

Extension got disconnected, replenishing connections...

I'm using Chrome v116 and Node v18.16.1.

Also, I added a Markdown linter to format the README.

rafael-mindreau commented 1 year ago

I fails to show the login widget in the showcase for me. I see in the console 10.000s of messages that say

Extension got disconnected, replenishing connections...

I'm using Chrome v116 and Node v18.16.1.

Also, I added a Markdown linter to format the README.

Thanks for adding that linter!

I'm not able to replicate exactly your issue, if you try to open the showcase app when the extension is not installed, it will throw some errors.

Also, if the extension has a general failure, the showcase was not really designed to catch those errors yet, so it might infinitely try to reach the mothership. These issues are often fixed by refreshing the extension (pressing update in the extensions page):

image

Please let me know if this issue persists.

pheyvaer commented 1 year ago

It still doesn't work.

rafael-mindreau commented 1 year ago

It still doesn't work.

Are you trying to log in with an identity created on solid playground which no longer exists? (created yesterday)

pheyvaer commented 1 year ago

It still doesn't work.

Are you trying to log in with an identity created on solid playground which no longer exists? (created yesterday)

No, I'm using my own WebID and pod.

pheyvaer commented 1 year ago

@rafael-mindreau I got it working. The EXTENSION_ID in identityPlugin.js didn't match the ID that my Chrome instance gave the extension. Should it have?

rafael-mindreau commented 1 year ago

@rafael-mindreau I got it working. The EXTENSION_ID in identityPlugin.js didn't match the ID that my Chrome instance gave the extension. Should it have?

Oh WOW! Good that you mention that, because I've totally forgotten about this. When I added this into the code, I suspected that this might not be static. I had an existential crisis trying to replicate this issue, so I'm glad you found it. I will add this into documentation!

pheyvaer commented 12 months ago

Instead of merging, you need to push this code to main of https://github.com/SolidLabResearch/solid-identity-manager