search

KOBENDigital / ConditionalDisplayers

Collection of modified Umbraco property editors to make them able to control the display of other properties in the same document type.
9 stars 14 forks source link

No strongly typed values in model #5

Closed ReVoid closed 5 years ago

ReVoid commented 5 years ago

When working with property on backend it returns always object value. It forced developers to use Model.GetPropertValue syntax instead of strongly typed 

if(Model.MyConditionalDisplayer)
{ 
     // something cool
}

Would be perfect to use both ways

skartknet commented 5 years ago

This should be fixed on v1.2 with the value converter. My internal tests are done using the strongly typed mode.

ReVoid commented 5 years ago

This should be fixed on v1.2 with the value converter. My internal tests are done using the strongly typed mode.

May be something went wrong with nuget update in my case, i didn't notice adding adding value converters. I will re-check

skartknet commented 5 years ago

Weird. I'll check the package as well.

ReVoid commented 5 years ago

Weird. I'll check the package as well.

I have checked now on version 1.3.0 with nuget in steps: Delete existing package Install new package Rebuild models

And...editors returns objects :(

But next, I overrided the package from backoffice package install section. And....now it returns bool as expected.

I can't explain that behavior. Where can I find the value converter dll in solution?

skartknet commented 5 years ago

Hey @ReVoid are you still having this issue?

ReVoid commented 5 years ago

Hey @ReVoid are you still having this issue?

I can't check it soon, sorry. So, I don't know :(

skartknet commented 5 years ago

No problem. I'll close it for now. Please reopen it if the issue persists.