search

KOBENDigital / ConditionalDisplayers

Collection of modified Umbraco property editors to make them able to control the display of other properties in the same document type.
9 stars 14 forks source link

Nested Content inside of Stacked Content #7

Closed bgunnarsson closed 5 years ago

bgunnarsson commented 5 years ago

I have a CD checkbox inside a nested content item which is then inside of a stacked content item and no fields are hidden, everything is shown (default). I'm currently checking if I can fix the issue.

skartknet commented 5 years ago

ConditionalDisplayers uses the 'data-element' attribute to target the elements. You should check if the properties in Nested Content or Stacked Content are missing that attribute.

image

bgunnarsson commented 5 years ago

You're right, they are missing that data attribute. nc

bgunnarsson commented 5 years ago

I'm currently working on a fix that I will then be creating a PR for in the Umbraco-CMS core repo.

bgunnarsson commented 5 years ago

https://github.com/umbraco/Umbraco-CMS/pull/6150

bgunnarsson commented 5 years ago

If this will be merged before 7.15.2 then if you want to use this package with NestedContent then the minimum version will be 7.15.2. The data-attribute will be like this -> data-property="property-nested___[alias]"

skartknet commented 5 years ago

Thanks @bgunnarsson but not sure if Umbraco will release new 'features' any more. I think they will just support v7 for a few years and will only release security patches.

bgunnarsson commented 5 years ago

I'm pretty baffled by that they marked this as a feature since it's clearly an oversight - The normal property editors have this and not the NestedContent ones which in turn breaks this package and other packages that rely on that data-attribute. A clear bug in my books.

bgunnarsson commented 5 years ago

IF this gets fixed in v8 then great. I'll just handle v7 differently

skartknet commented 5 years ago

You're right, I think they should release bugs fixes while they give support to v7. Anyways, I'm sure this will be fixed on v8.

bgunnarsson commented 5 years ago

This will be coming in 7.15.3 and 8.1.4 👍