KOF-ch / tstools

A time series toolbox for official statistics
11 stars 4 forks source link

Right align axis label for r-h-s axis #270

Closed heinermikosch closed 6 years ago

heinermikosch commented 6 years ago

When graphs come with a right-hand-side axis, it would be optimal to align the axis label (if existing) to the right-hand-side by default. At the moment, there seems to be some kind of left-hand-side alignment. Example below: "(in Mio.)" is not aligned to the righ-hand-side axis. example

HomoCodens commented 6 years ago

This is already possible via the subtitle_adj_r theme-parameter:

library(tstools)
tsplot(
  generate_random_ts(3),
  tsr  = generate_random_ts(2, seed = 2),
  plot_title = "bla",
  plot_subtitle = "left subitle",
  plot_subtitle_r = "right subtitle",
  theme = init_tsplot_theme(subtitle_adj_r = 1))

This parameter specifies the position of the right edge of the right subtitle as a fraction of plot width.

Kind of raises the question why we set the default to .9 though.

mbannert commented 6 years ago

@heinermikosch thanks for reporting this. I think @HomoCodens is right we should make this a default. @heinermikosch do you think there are any problems layout wise with VJA or any other outlets? I'll point CC to this thread and ask for their opinion.

heinermikosch commented 6 years ago

«Kind of raises the question why we set the default to .9 though.» Setting default to 1.0 (= full right align) would suit us. “@heinermikoschhttps://github.com/heinermikosch do you think there are any problems layout wise with VJA or any other outlets?” As I see it, this makes some graphs in the KOF publicatons better, without making any graph worse.

From: Matt Bannert notifications@github.com Sent: Dienstag, 30. Oktober 2018 15:35 To: mbannert/tstools tstools@noreply.github.com Cc: Mikosch Heiner mikosch@kof.ethz.ch; Mention mention@noreply.github.com Subject: Re: [mbannert/tstools] Right align axis label for r-h-s axis (#270)

@heinermikoschhttps://github.com/heinermikosch thanks for reporting this. I think @HomoCodenshttps://github.com/HomoCodens is right we should make this a default. @heinermikoschhttps://github.com/heinermikosch do you think there are any problems layout wise with VJA or any other outlets? I'll point CC to this thread and ask for their opinion.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mbannert/tstools/issues/270#issuecomment-434324539, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ac2BpF9UP-ELtW13cByEwgbz6zajk3nNks5uqGN5gaJpZM4YBuNe.

mbannert commented 6 years ago

@HomoCodens can you post a plot that looks like what @heinermikosch suggests so others have an easier time giving their 2cents.

HomoCodens commented 6 years ago

rplot10