search

KOOKIIEStudios / PalCON-Discord

A Python-based Discord bot for PalWorld server administration via RCON
MIT License
18 stars 3 forks source link

Refactor Sync Functionality into a Standalone Command #11

Closed alexraskin closed 6 months ago

alexraskin commented 7 months ago

This PR restructures how the bot handles syncing slash commands with discord. Previously, the sync operation was automatically triggered within the on_ready event, which could lead to unintended behavior and limited control over when and how synchronization occurred.

Command Implementation: The sync function has been encapsulated into a new command, !sync. This command can be invoked by users with appropriate permissions.

Testing: Verify that the !sync command responds as expected.

Updated the README and command documentation to include information about the new !sync command, including usage examples and permission requirements.

alexraskin commented 6 months ago

@KOOKIIEStudios Is this okay to merged in?

Bratah123 commented 6 months ago

@KOOKIIEStudios Is this okay to merged in?

I think we decided to keep the sync on start, just cause we want the project to be as PnP as possible. Especially for people who are setting up the bot with little technical experience. TLDR; we are trying to avoid adding anymore steps to the initial set up. We think the risk of them rate-limiting themselves is low.

alexraskin commented 6 months ago

@KOOKIIEStudios Is this okay to merged in?

I think we decided to keep the sync on start, just cause we want the project to be as PnP as possible. Especially for people who are setting up the bot with little technical experience. TLDR; we are trying to avoid adding anymore steps to the initial set up. We think the risk of them rate-limiting themselves is low.

Fair enough!