KOYK / Tiberian-Dawn-Original

The Original Tiberian Dawn In OpenRa Engine
GNU General Public License v3.0
8 stars 1 forks source link

Fix weapons that should fire above or blocked by concrete walls #66

Open KOYK opened 4 years ago

KOYK commented 4 years ago

@MikillRosen at discord provided a compact list of the units that can fire over concrete walls and units that can't fire over walls.

sayedmamdouh List below:

APC can't shoot over walls Medium Tank can't shoot over walls Minigunner can't shoot over walls Rocket Soldier can shoot over walls Grenadier can shoot over walls Orca can shoot over walls Apache can't shoot over walls (in spite of being in flight) Chemical Warrior can't shoot over walls Flamethrower can't shoot over walls (but his AOE can) Recon Bike can shoot over walls Rocket Launcher can shoot over walls Nod Buggy can't shoot over walls Hum-vee can't shoot over walls Light Tank can't shoot over walls Flame Tank can't shoot over walls (but its AOE can) Mammoth Tank's cannons can't shoot over walls Mammoth Tank's missiles can shoot over walls Artillery can shoot over walls SSM Launcher can shoot over walls SAM Site can shoot over walls Obelisk of Light can shoot over walls Advanced Guard Tower can shoot over walls Turret can't shoot over walls Guard Tower can't shoot over walls Commando can't shoot over walls Stealth Tank can shoot over walls

MustaphaTR commented 4 years ago

In RA MG weapons could shoot over walls, but since that doesn't make much sense i tied to to a checkbox and made them blocked by default in RA Classic. Are you certain that that is not the case here?

KOYK commented 4 years ago

There are many things that don't make sense to be honest, for example the mammoth tank can't crush walls not even sandbags, but I have to follow the original on every aspect. But I am thinking that I could make a checkbox option the final stages of the mod, that will be a balance edit. That will fix stuff like that.

Inq8 commented 4 years ago

It is a bit tricky with TD, yes the units with bullet weapons can't fire over concrete walls if you surround the target completely (with walls) because the pathfinder won't let them.

However, if you stand a Minigunner/Hum-vee/APC etc, beside a wall that does not enclose the target with a bullet weapon then they can fire over it fine. If they are away from the wall and you tell them to attack they will run to an open side of the target.

Inq8 commented 4 years ago

wall

As you can see here, this allows Guard towers to fire over walls.

Perhaps you could have ProximityExternalCondition on walls & two Armament's on each Bullet using unit so when they are within close range of the wall they ignore the Blockable state of the wall?

It is difficult to replicate.

KOYK commented 4 years ago

ive just test this, it seems that if you put 5 minigunners bellow the wall, only the top 3 on the cell will shoot beyond the wall, but in some other cases they will shoot only 2 of them and even 1, depending on the direction they are shooting.

But also I have placed a sam site above the wall and all 5 of them could shoot at it.

This is indeed tricky to solve as @Inq8 said.

ProximityExternalCondition could work to a point, but what makes it difficult is the fact that they all fire when they are ordered to attack on buildings beyond the wall, and not when set to force fire EDIT* on the ground.

Below is the test video linked from discord https://discordapp.com/channels/573807529243443210/573841702846988288/707176878997241886