Invalid code structure.

[danmarsden]

Hi There,

your code does not comply well with Moodle standard guidelines:

in particular:

• functions and in-line code should not be mixed - functions should sit within namespaced classes or within the locallib.php file.
• Functions must be namespaced correctly or must use the plugin frankenstyle prefix (mod_capquiz) - or because this is an activity module you can also just use "nscapquiz"
• In-line files (view.php/action.php etc) should call require_login at the top of the file (not in a wrapper function called by the file)
• In-line files should make appropriate capability checks at the top of the file (not in a wrapper function called by the file.)

This makes it hard to perform a complete review at this stage and blocks approval in the plugins db.

[sebastsg]

I've attempted to fix all the issues you have mentioned:

• no longer any free functions in any inline files besides lib.php (now static methods inside classes)
• require_login called on top of all inline files, never called inside functions
• require_capability and has_capability called after require_login, never called inside functions

(only in development branch as of writing this comment)