search

KRALYN / PositronV3

A upside-down, fast, portable, and compact 3D printer
Creative Commons Attribution 4.0 International
2.08k stars 233 forks source link

ZIP is not ideal in git repositories #11

Closed ascheucher closed 2 years ago

ascheucher commented 2 years ago

Hi KRALYN!

That's an awesome project! I am really tempted to rebuild the printer, but let's see whether I find time for that.

Just something I noticed, during checking your repo: ZIP files are not encouraged in git repositories. You will lose the possibility to track changes and also AFAIK, git compresses everything anyway on transfer and storage. It's just only drawbacks checking in zipped files.

Thanks for sharing your project!

KRALYN commented 2 years ago

How do I upload 100+mb files to Github then?

On Tue, May 31, 2022 at 10:56 AM Andreas Scheucher @.***> wrote:

Hi KRALYN!

That's an awesome project! I am really tempted to rebuild the printer, but let's see whether I find time for that.

Just something I noticed, during checking your repo: ZIP files are not encouraged in git repositories. You will lose the possibility to track changes and also AFAIK, git compresses everything anyway on transfer and storage. It's just only drawbacks checking in zipped files.

Thanks for sharing your project!

— Reply to this email directly, view it on GitHub https://github.com/KRALYN/PositronV3/issues/11, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP6KUFKJMYJK2N2JUVFUO4TVMYSAXANCNFSM5XN3XPTA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

The-Synthax commented 2 years ago

How do I upload 100+mb files to Github then?

Perhaps something such as git lfs

ascheucher commented 2 years ago

Never used git lfs, but this sounds like the proper way to do it.

luminous-flux commented 2 years ago

It works well for CAD - it just tells git to treat the files as pure binary blobs so it doesnt try to diff them as text with previous versions.

On Wed, Jun 1, 2022 at 5:32 PM Andreas Scheucher @.***> wrote:

Never used git lfs, but this sounds like the proper way to do it.

— Reply to this email directly, view it on GitHub https://github.com/KRALYN/PositronV3/issues/11#issuecomment-1144158811, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARI5NQ7HJAJ3ZDXTYQAOXS3VM7JE7ANCNFSM5XN3XPTA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

KRALYN commented 2 years ago

I think this application of Zip is fine since it is an CAD assembly.