KRR-Oxford / RSAComb

Re-implementation of the combined approach for CQ answering over RSA ontologies
https://www.cs.ox.ac.uk/isg/tools/RSAComb
Apache License 2.0
2 stars 0 forks source link

RSAComb testing suite #9

Open dyamon opened 3 years ago

dyamon commented 3 years ago

We clearly need to automate testing better that how it is atm.

Unit testing

Unit testing is almost useless when it comes to modules that depend on generating "fresh names" since we can't predict the names of the generated names.

The simple solution is to put the code that generates fresh names into its own class and keep track of the seed as an implicit parameter to the generation function. This won't break the existing code, will keep the seed "out of the way" when we don't need it, but will give us the ability to run unit tests on the same seed.

Note: unit testing is also incomplete on most modules so it might be worth spending some time on that.

Test cases

Along the way we collected a fair amount of interesting (and correct) test cases. We should integrate them with some GitHub Action so that we don't break the existing code while introducing new features.