search

KRSSG / robocup

Main Code Base for SSL
21 stars 27 forks source link

Cleanup beliefatate #26

Closed shamin1998 closed 5 years ago

shamin1998 commented 5 years ago

Fixes #19 Removed: (commented out) 1) opp_bot_marking_our_attacker 2) ball_at_corners 3) ball_in_our_possession

As only belief_state/src/node_class.cpp is being used and not node.cpp or node1.cpp I've only made changes to node_class.cpp

Hence also commented out the command to compile node.cpp from belief_state/CMakeLists.txt

saurabhkgp21 commented 5 years ago

Remove every predictions other than velocities from beliefstate and add them into utils/state_function.py

saurabhkgp21 commented 5 years ago

Goalie id of both teams will be taken from referee msg

shamin1998 commented 5 years ago

Is the referee msg published on any topic?

saurabhkgp21 commented 5 years ago

yeah... but it hasnt been integrated with this code-base

shamin1998 commented 5 years ago

So is there any other way to take goalie ids from referee for now?

Shamin Aggarwal 2nd year Undergraduate Computer Science and Engineering Department IIT Kharagpur

On Thu 24 Jan, 2019, 4:44 PM Saurabh Agarwal <notifications@github.com wrote:

yeah... but it hasnt been integrated with this code-base

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KRSSG/robocup/pull/26#issuecomment-457160691, or mute the thread https://github.com/notifications/unsubscribe-auth/Ag8Lat6v46K2eGPcTFbGBMue0gsZh0VLks5vGZWtgaJpZM4ZBNP_ .

saurabhkgp21 commented 5 years ago

Where do you need goalie id?

shamin1998 commented 5 years ago

Nah, we don't need it as such. You'd only commented that the goalie id has to be taken from referee msg. Else should I just remove it from beliefstate?

Shamin Aggarwal 2nd year Undergraduate Computer Science and Engineering Department IIT Kharagpur

On Thu 24 Jan, 2019, 5:14 PM Saurabh Agarwal <notifications@github.com wrote:

Where do you need goalie id?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KRSSG/robocup/pull/26#issuecomment-457168198, or mute the thread https://github.com/notifications/unsubscribe-auth/Ag8Lalcxlg_9fW6p37iBpcjhFeZf34peks5vGZyAgaJpZM4ZBNP_ .

saurabhkgp21 commented 5 years ago

Yeah just comment it for now.. If there will be any need of taking goalie id before integrating referee comm we will uncomment it

shamin1998 commented 5 years ago

Ok

Shamin Aggarwal 2nd year Undergraduate Computer Science and Engineering Department IIT Kharagpur

On Thu 24 Jan, 2019, 5:38 PM Saurabh Agarwal <notifications@github.com wrote:

Yeah just comment it for now.. If there will be any need of taking goalie id before integrating referee comm we will uncomment it

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KRSSG/robocup/pull/26#issuecomment-457174456, or mute the thread https://github.com/notifications/unsubscribe-auth/Ag8Lao3z2wWCCCtEue7GVYdR48btqCO1ks5vGaIygaJpZM4ZBNP_ .