search

KRTirtho / flemozi

Advanced⚡ Emoji Picker😀 for Linux🐧, Windows🪟 and macOS🍎
GNU General Public License v3.0
210 stars 5 forks source link

Add a link to the AUR package #5

Closed christian-heusel closed 1 year ago

christian-heusel commented 1 year ago

This add a link to the AUR package of flemozi to the README.md :+1:

christian-heusel commented 1 year ago

Regarding the PKGBUILD there is quite some room for improvements. i.e. the following line is rather sketchy: https://github.com/christian-heusel/aur/blob/251d67555332d5bff77ea382d194f220688cb86f/flemozi/PKGBUILD#L23

Could you fix the need for the env file and solve it via cmd parameters? 😄 Also let me know if you have other suggestions!

KRTirtho commented 1 year ago

Flemozi needs a Giphy and a Tenor API key to enable GIF (JIF not GIF :upside_down_face: ) support. Building it from source requires TENOR_API_KEY & GIPHY_API_KEY to be available. We can theoretically just pass TENOR_API_KEY & GIPHY_API_KEY as env vars when running the app or add these to .bashrc or .zshrc

KRTirtho commented 1 year ago

But in future I'll add an option to override and store these credentials in flemozi

KRTirtho commented 1 year ago

Btw, flemozi needs libkeybinder3 maybe? This is a required dependency for non-wayland systems

christian-heusel commented 1 year ago

Btw, flemozi needs libkeybinder3 maybe? This is a required dependency for non-wayland systems

Yes libkeybinder and the flutter deps are currently missing, I will improve that today: https://github.com/christian-heusel/aur/issues/1

Edit: dependency bugs are now fixed, if you have any idea about the other two points just let me know. 👍🏻

KRTirtho commented 1 year ago

I'm merging this for now. We'll track the aur issues in your repo