search

KRTirtho / metadata_god

Audio file Metadata reading and writing library for Flutter
MIT License
23 stars 12 forks source link

Use lofty-rs for metadata instead of audiotags #17

Closed FriederHannenheim closed 1 year ago

FriederHannenheim commented 1 year ago

This is a bit of a quick and dirty implementation. The api could be changed so that not so many type conversions would be needed. I'm not really sure how the bindings work though so I didn't change it now. This fixes #15 and enables reading many more types of tags. Downside: album_artist isn't supported by lofty and is just mapped to artist

FriederHannenheim commented 1 year ago

Wait. Don't merge this yet. Lofty does support album artist. I just didn't see it since there is no direct method for it.

FriederHannenheim commented 1 year ago

Alright. Album Artist is now working correctly

KRTirtho commented 1 year ago

Wow that's a wonderful and huge work :heart: :rocket:

KRTirtho commented 1 year ago

@FriederHannenheim sorry for the delay. I've checked it and your implementation works quite well

KRTirtho commented 1 year ago

But what will do about the CHANGELOG, CMakeLists.txt and pubspec.yaml changes? After merging this I'm planning to publish it as v0.5.0

Since you're actively using the fork's main branch aka this branch in an app I suggest you to close this PR and create a new one with pubspec, CHANGELOG, and CMakeLists.txt changes reverted using a separate branch

FriederHannenheim commented 1 year ago

Alright new, cleaner pull request is #21