search

KRTirtho / metadata_god

Audio file Metadata reading and writing library for Flutter
MIT License
23 stars 12 forks source link

Add iOS and macOS support #3

Closed mouEsam closed 2 years ago

mouEsam commented 2 years ago

This PR adds support for macOS and iOS.

Closes #1

KRTirtho commented 2 years ago

Does the example app runs perfectly fine one macOS? (with actual audio file path) :smiley:

mouEsam commented 2 years ago

The example runs and loads the library fine. I’ll test an actual audio file and post the result.

KRTirtho commented 2 years ago

Thanks man. You're awesome

mouEsam commented 2 years ago

Confirmed! The library works fine. You can merge safely.

KRTirtho commented 2 years ago

Hey looks like macos version is not working and the example app throwing following error image

KRTirtho commented 2 years ago

Looks like macos/Frameworks/rust_crate.framework/Versions/A/rust_crate is a static reference so it won't work anywhere except your own macOS instance :sweat_smile: . Can't we directly put the librust.dylib in macos/Frameworks/rust_crate.framework/Versions/A renaming to rust_crate?

mouEsam commented 2 years ago

Looks like the issue is with the symbolic link in the framework. I’ll look into it.

shadow5688 commented 11 months ago

@mouEsam can https://github.com/KRTirtho/metadata_god/issues/26 be looked into please?

mouEsam commented 11 months ago

@mouEsam can https://github.com/KRTirtho/metadata_god/issues/26 be looked into please?

Gladly tomorrow 👍

shadow5688 commented 11 months ago

Gladly tomorrow 👍

Hey @mouEsam, Were you able to look into it? If there's something needed from my end, then lemme know