KRTirtho / spotube

🎧 Open source Spotify client that doesn't require Premium nor uses Electron! Available for both desktop & mobile!
https://spotube.krtirtho.dev/
Other
28.64k stars 1.18k forks source link

Add Spotube to Homebrew #120

Open eriktiekstra opened 2 years ago

eriktiekstra commented 2 years ago

Is your feature request related to a problem? Please describe. Installation of Spotube on a Mac currently only is available by downloading the dmg from Github. It would be great to be able to use a package-manager (Homebrew) for this.

Describe the solution you'd like Add Spotube to Homebrew casks

Describe alternatives you've considered N/A

Additional context N/A

KRTirtho commented 2 years ago

Literally have no idea about homebrew although have heard sometimes about it. Never been a user in the Apple Garden at all. So its kind of hard for me to deal with this. Also I don't own a Mac. So, kind of impossible I think since Apple has their so called "policy" of not even letting developers develop applications for their Platform without buying their products

I guess, it'd more viable if someone who owns a Mac maintains & publishes the homebrew stuff on behalf of this project

kiblik commented 1 year ago

Hi there,

I wanted to add Spotube to Homebrew: https://github.com/Homebrew/homebrew-cask/pull/145688 Unfortunately, the audit doesn't pass because of a missing signature. Is it possible to fix it?

audit for spotube: failed
 - Signature verification failed:
/private/tmp/d20230423-3158-rup9bx/spotube.app: rejected

macOS on ARM requires software to be signed.
Please contact the upstream developer to let them know they should sign and notarize their software.
Error: 1 problem in 1 cask detected
KRTirtho commented 1 year ago

Spotube macos is certainly missing signing. I'm unable to do that as it requirese access to XCode to generate certificates for the app

kiblik commented 1 year ago

Spotube macos is certainly missing signing. I'm unable to do that as it requirese access to XCode to generate certificates for the app

I have no experience with MacOS development but I suppose it should be possible to handle it in Github Action somehow, shouldn't it? It would also increase credibility of the whole Spotube in general.

https://docs.github.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development

razvanazamfirei commented 1 year ago

Signing would still require a certificate.

KRTirtho commented 1 year ago

And I can't issue a certificate without mac :'(

kiblik commented 1 year ago

And I can't issue a certificate without mac :'(

I might help in this step :) I will look at it

JounQin commented 8 months ago

I've just added it into my tap https://github.com/homebrew-x/homebrew-x

Usage

brew install homebrew-x/x/spotube
martin-braun commented 8 months ago

@JounQin Thanks for taking action, although instead of making your own tap, it would be so much better if the signing issue could be solved.

@KRTirtho Who's building the binary and adding that to Github? The same person / process can sign the app for you.

JounQin commented 8 months ago

it would be so much better if the signing issue could be solved.

Sure, but custom tap is much better for such non signed apps.

@KRTirtho can also host it as https://github.com/KRTirtho/homebrew-spotube for example, no signing required at all.

gatspy commented 7 months ago

Looking forward to homebrew's release

JounQin commented 7 months ago

Such comments do not help anything.

gmcinalli commented 7 months ago

Here's an example of a Homebrew Cask tap hosted on GitHub.

https://github.com/th-ch/homebrew-youtube-music

JounQin commented 7 months ago

@gmcinalli Didn't you see https://github.com/KRTirtho/spotube/issues/120#issuecomment-1876439571?

gmcinalli commented 7 months ago

@JounQin Yes, sorry. Just wanted to help understand better with a very similar project.

Kairixir commented 6 months ago

I might help in this step :) I will look at it > [Feature] Install with brew #409

Sadly this is a Catch 22. Only someone @KRTirtho trusts should create the certificate so the private key stays secret. At the same time @KRTirtho does not have Mac.

The only solution I see is either: @KRTirtho adds a person he trusts to the project so they create the certificate for this app, or @KRTirtho gets his hands on some Mac.

btw. I found an article showing how to automate the signing process using GitHub Actions


@KRTirtho can also host it as https://github.com/KRTirtho/homebrew-spotube for example, no signing required at all. https://github.com/KRTirtho/spotube/issues/120#issuecomment-1876471442

Sounds like the best option to me, unless the certificate is created. btw. Thank you, @JounQin, for the Tap you've created.

Kairixir commented 6 months ago

After re-reading the README.md — maybe @karniv00l can help?

KRTirtho commented 6 months ago

@Kairixir don't worry pal. I can now create one since I've recently got a mac. I'll try to add it to homebrew and even get it notarized by Apple. I was just learning the new mac ecosystem for the past month. Otherwise, 3.4.1 would've been in homebrew 😄

TBH the new keyboard layout, it's killing me lol 🤣

KRTirtho commented 6 months ago

Well I tried to create a Developer ID but unfortunately, Apple doesn't accept Bangladeshi developer account applications https://forums.developer.apple.com/forums/thread/127494 https://discussions.apple.com/thread/255363512

So I temporarily created a tap repository and everyone should be able to use it to install spotube through homebrew

$ brew tap krtirtho/apps
$ brew install --cask spotube
KRTirtho commented 6 months ago

I'll update the README too

AITleo commented 4 months ago

This issue can be closed, right?

https://github.com/KRTirtho/spotube/blob/master/README.md?plain=1#L137

binaryben commented 4 months ago

This issue can be closed, right?

Depends. Might still be open to track not needing a custom tap or other things