KRTirtho / spotube

🎧 Open source Spotify client that doesn't require Premium nor uses Electron! Available for both desktop & mobile!
https://spotube.krtirtho.dev/
Other
26.67k stars 1.09k forks source link

Alternative track source does not persist after closing the app. #1223

Open HeyItsFiore opened 5 months ago

HeyItsFiore commented 5 months ago

Is there an existing issue for this?

Current Behavior

Although the patch notes said it should be fixed, when I select a new alternative track source and close the app, it goes back to the original selection ignoring my choice.

Expected Behavior

After selecting a new alternative track source, it should be mantained even after closing the app and not reset to the original choice.

Steps to reproduce

  1. Opened Spotube
  2. Started a song, wrong track
  3. Selected the new track
  4. Closed Spotube
  5. Reopened Spotube, song was back on the wrong track

Operating System

Windows 11

Spotube version

v3.4.1 (latest)

Installation source

GitHub Releases (Binary)

Additional information

This is especially strange since I managed to keep only one song with an alternative track source, but any other just revert back. I did try uninstalling and reinstalling, no changes. This is technically a duplicate of #840, but it's not resolved for me.

Self grab

KRTirtho commented 5 months ago

Can you specify what song(s) it's happening with? Because I was unable to reproduce this issue.

As long as you've not changed the audio source ("Settings" > "Audio Source") before playing that particular song once again, it should remember the manually selected match

crbenne commented 5 months ago

I'm also having the same issue -- this is the song https://open.spotify.com/track/57gvyHE7smXf3gaRH794lt

Something quite odd, at first it plays an episode from the Critical Role podcast. If I look at the alternative sources, there are none unless I click the magnifying glass and change the search from "lievery voice - main vox mix - Jasper Street Co., Mousse T." to "lift every voice - main vox mix - Jasper Street Co., Mousse T." (for some reason the "ft" is missing from the original search.

When I choose the alternative track, it will remember the selection until I close and reopen Spotube, then it goes back to the original result

KRTirtho commented 5 months ago

Looks like the regex that cleans the track title is removing the ft from lift thus it's lievery song -....

KRTirtho commented 5 months ago

This line is the culprit

https://github.com/KRTirtho/spotube/blob/5d0b5e69a5e43b17561656160fd963de4ff0f833/lib/utils/service_utils.dart#L57

It should match the whole word only but it's replacing parts of the word and there should've been a \ before . so it'll detect it as a fullstop instead of a regex operator

KRTirtho commented 5 months ago

@crbenne Fixed in 86123456f2ff577921cf62cffca180427dfe1dd5

But your actual issue was related to #883 not this one

HeyItsFiore commented 4 months ago

Can you specify what song(s) it's happening with? Because I was unable to reproduce this issue.

As long as you've not changed the audio source ("Settings" > "Audio Source") before playing that particular song once again, it should remember the manually selected match

Sorry for the late reply! Basically, any of them; I'm testing right now with https://open.spotify.com/track/46scODShYFATHbLfLE0dr1 (it finds the Midnight version) or https://open.spotify.com/track/6rdkCkjk6D12xRpdMXy0I2 (completely wrong song). If I select them manually after failing the first time, it is mantained. But if I close and open the app again, the choice is forgotten and I have to select again which songs are the right ones. I am not changing the audio source between uses of the app, by the way. Thank you for your help!

BloodRaven0 commented 2 months ago

@KRTirtho This is still happening on Spotube 3.6.0 on Windows 10.

When changing the source of this song (https://open.spotify.com/track/7uUoiK8yQQrsuk5iF1dlFA), no alternatives come up until you click the Search button (this happens to all songs by the way). Manually selecting the Official Audio version causes it to play correctly, but as soon as it goes to the next or previous song, then back to this one, or exiting the app and reopening it again, the default source is back to the Official Video version.

I don't think it's an issue specific to this song, it happens on any song I've tried it so far. Let me know if I can help resolve this issue by testing and troubleshooting further. :)

KRTirtho commented 1 week ago

This has been fixed in #1687