search

KRTirtho / spotube

🎧 Open source Spotify client that doesn't require Premium nor uses Electron! Available for both desktop & mobile!
https://spotube.krtirtho.dev/
Other
30.71k stars 1.27k forks source link

Spotube connect should display other devices by their hostname #1810

Open SilPan opened 2 months ago

SilPan commented 2 months ago

Is there an existing issue for this?

Current Behavior

When using spotube connect, where I have my PC set to be remote controlled and I select it as a target on my phone, the menu lists the PC as "GNOME" instead of it's hostname.

Expected Behavior

I would expect to identify other computers by their hostname. It's what spotify connect does and what all other services do.

Steps to reproduce

  1. set Spotube on PC to 'Enable Connect'
  2. see available devices on phone
  3. wonder about the name of the listed device

Operating System

KDE neon + Android

Spotube version

flatpak 3.7.1 + android 3.8.0

Installation source

F-Droid (Android), Flathub (Flatpak)

Additional information

Interestingly my PC is identified as Gnome, even though I use KDE Plasma as a desktop, this has probably to do with the fact that I am using the flatpak version of spotube and it uses the gnome platform.

Self grab

SilPan commented 2 months ago

Maybe that's an 'enhancement' not a 'bug'.