KRTirtho / spotube

🎧 Open source Spotify client that doesn't require Premium nor uses Electron! Available for both desktop & mobile!
https://spotube.krtirtho.dev/
Other
30.7k stars 1.27k forks source link

Stop overriding the registry value for default spotify links handler #1997

Open EDM115 opened 1 month ago

EDM115 commented 1 month ago

Is there an existing issue for this? (Please read the description)

Current Behavior

After installing Spotube, opening any Spotify link (in a browser for example) will attempt to open the said link in the app that supports it. But when Spotify and Spotube are installed at the same time, Spotube will override this behavior.
As far as I can tell, it overrides the value of HKEY_CLASSES_ROOT\spotify\shell\open\command to be "D:\EDM115\Programmes\Spotube\spotube.exe" "%1" (default value).

Expected Behavior

Having Spotube overriding this is okay, but we should have either the choice in the settings to change that, or at least in the installer when Spotify is also present.

Steps to reproduce

  1. Install Spotube and Spotify
  2. Open a Spotify link in a browser (ex : https://goo.gl/B3AWV5)
  3. Note that it proposes to open in Spotube and not Spotify

image

Logs

Not relevant

Operating System

Windows 11

Spotube version

v3.8.3

Installation source

WinGet (Windows)

Additional information

No response

Self grab

EDM115 commented 1 month ago

oh and for anyone wanting to set it back to Spotify :

EinsKatze commented 4 weeks ago

Maybe add an option in settings "Open Spotify Links in spotube" - cuz i personally like it that the links open in spotube