search

KRTirtho / spotube

🎧 Open source Spotify client that doesn't require Premium nor uses Electron! Available for both desktop & mobile!
https://spotube.krtirtho.dev/
Other
26.54k stars 1.09k forks source link

Tray icon has no image and is improperly captalized #541

Open RaptaG opened 1 year ago

RaptaG commented 1 year ago

Is there an existing issue for this?

Current Behavior

image

Expected Behavior

The Spotube icon and proper capitalization

Steps to reproduce

  1. Open the app
  2. Look at your system tray
  3. Hover over an invisible spot
  4. See issue

Operating System

Fedora Linux Kinoite 38

Spotube version

3.0.0

Installation source

Flathub (Flatpak)

Additional information

No response

benmordecai commented 11 months ago

Same problem for me on Arch, KDE, X11 with flatpak

HobieCat commented 11 months ago

Same here, on KDE Neon, X11 with flatpak

thaislanr commented 11 months ago

Same problem here, on Arch Linux KDE Plasma 5.27.6, Wayland with Flatpak.

KRTirtho commented 10 months ago

Issue with an underlying plugin system_tray. I already created a issue on plugin upstream https://github.com/antler119/system_tray/issues/67

callegar commented 8 months ago

Can it be the case you need libatayana-appindicator3 rather than libappindicator3?

Changing libayatana-appindicator3.so.1 for the libappindicator3.so.1 in the Appimage fixes the icon issue here.

ninja- commented 4 months ago

The passed icon path is not visible outside sandbox. It should be something like this, after copying to tmp file.

     variant             string "/run/user/1006/app/org.chromium.Chromium/.org.chromium.Chromium.umEnqv"

However, I am struggling to find the correct env that automatically creates this magic path, as it doesn't seem to be any directory in standard envs provided by flatpak. XDG_CACHE_HOME=/home/user2/.var/app/org.app.id/cache

XDG_CACHE_HOME could be a quick-and-dirty hack until it's figured out, while it's called cache, it's never actually automatically cleaned

C-512L commented 4 months ago

The passed icon path is not visible outside sandbox. It should be something like this, after copying to tmp file.

     variant             string "/run/user/1006/app/org.chromium.Chromium/.org.chromium.Chromium.umEnqv"

However, I am struggling to find the correct env that automatically creates this magic path, as it doesn't seem to be any directory in standard envs provided by flatpak. XDG_CACHE_HOME=/home/user2/.var/app/org.app.id/cache

XDG_CACHE_HOME could be a quick-and-dirty hack until it's figured out, while it's called cache, it's never actually automatically cleaned

The variables for the path you are referring to are $XDG_RUNTIME_DIR (/run/user/1006) and $FLATPAK_ID (org.chromium.Chromium) respectively. Also I think that's the Electron specific way of doing it, which doesn't work on Flutter (correct me if i'm wrong). As I mentioned on https://github.com/flathub/com.github.KRTirtho.Spotube/pull/51#issuecomment-1908986589 I think the best solution on flatpak might be to use the $FLATPAK_ID identifier directly and let the system handle finding the icon itself.

RayJW commented 3 months ago

I think it would make sense to switch the library used to create tray icons. The current one is not maintained any more and causes a bunch of issues. Other projects are doing the same, e.g. https://github.com/localsend/localsend/pull/1255, and it would resolve a lot of issues with relatively little work.

Peperehobbits01 commented 1 month ago

I have the same issues on Linux mint Cinamon 20.3 whit the flathub version https://github.com/KRTirtho/spotube/issues/1302

Peperehobbits01 commented 3 weeks ago

It seems that this bug is kinf of fixed, tho to be fair the logos is still missing in my case, at least now there is a icon showing up, anyway, if your issues is fixed please close this issues 😉