KRTirtho / spotube

🎧 Open source Spotify client that doesn't require Premium nor uses Electron! Available for both desktop & mobile!
https://spotube.krtirtho.dev/
Other
28.43k stars 1.17k forks source link

Cache songs instead of downloading externally. #709

Closed devanarayanan44 closed 2 weeks ago

devanarayanan44 commented 11 months ago

Is there an existing issue for this?

Pain

If I download a song and play it from the artist page or from a playlist, it plays online. I can't view the lyrics of downloaded tracks. I can't go to the album or artist from the downloaded tracks.

Suggested solution

Cache the songs (like inner tune) and add a separate option for downloading externally.

Useful resources

No response

Additional information

No response

KRTirtho commented 11 months ago

Does caching music really make sense? Most of the users doesn't listen to the same song twice in a day (or even weeks) without special reason. So if we cache songs (save them on the storage) we also must need to set a custom cache limit after which old songs will get removed So if songs are getting added constantly & old ones are getting removed to make space then is there any point of caching here? We're doing nothing but wasting space in glorified way. Which official Spotify app does a lot btw (over 2-3GB occupied cache space)

Btw caching song is a really tough thing to implement & time consuming (implementation for each platform)

ZenKyma commented 11 months ago

I assume the idea is to have a button to make tracks available offline (apart from download) for listening through spotube and enjoying the lyrics, by caching the respective content. The problem of a cache limit would be eliminated if the user has to manage his cached content himself, e.g. through the respective button, a more advanced option would be a 'cached-content' interface.

Actually this was the behaviour I also expected when first seeing the download option.

devanarayanan44 commented 11 months ago

I assume the idea is to have a button to make tracks available offline (apart from download) for listening through spotube

Exactly.

siggi1984 commented 11 months ago

Does caching music really make sense? Most of the users doesn't listen to the same song twice in a day (or even weeks) without special reason. So if we cache songs (save them on the storage) we also must need to set a custom cache limit after which old songs will get removed So if songs are getting added constantly & old ones are getting removed to make space then is there any point of caching here? We're doing nothing but wasting space in glorified way. Which official Spotify app does a lot btw (over 2-3GB occupied cache space)

Btw caching song is a really tough thing to implement & time consuming (implementation for each platform)

A song cache function would be very useful and helpful. I would be very happy about such a function.

AozoraDev commented 11 months ago

Caching is probably useful, since i'm always listening to my Liked Tracks.... I mean... i know i can use mass download but it's kind of pain in the ass imo.

OmG3r commented 10 months ago

an alternative/enhancement is to simply offer a setting to download all songs you listen to by default, songs will be available in the download specified

KRTirtho commented 1 month ago

It's actually somewhat possible now since spotube now uses a custom streaming proxy inside the app, so we could cache the stream in file. It might occupy more storage.

ZenKyma commented 1 month ago

Great news! It's totally expected to occupy storage when you cache music locally, I guess that's the deal for enjoying it offline ;)

siggi1984 commented 1 month ago

It's actually somewhat possible now since spotube now uses a custom streaming proxy inside the app, so we could cache the stream in file. It might occupy more storage.

Does that mean that the songs you listen to are saved and can be played offline the next time you play them? That would be great and would save mobile data for those who don't have that much.

KRTirtho commented 2 weeks ago

Duplicate of #127

Can't believe there's been a parent issue all this time