KRTirtho / spotube

🎧 Open source Spotify client that doesn't require Premium nor uses Electron! Available for both desktop & mobile!
https://spotube.krtirtho.dev/
Other
26.42k stars 1.08k forks source link

google home/assistant integration #956

Open ThrosturX opened 6 months ago

ThrosturX commented 6 months ago

Is there an existing issue for this?

Pain

When I ask google assistant to play music with spotube, it doesn't understand what I want.

Suggested solution

Add the appropriate integrations necessary for google home to recognize spotube as a music service provider.

Useful resources

https://developers.google.com/assistant/app https://developer.android.com/media/implement/assistant

Additional information

Details related to the service being integrated Steps that can be used to verify successful integration

KRTirtho commented 6 months ago

I wonder if it's possible.

ThrosturX commented 6 months ago

I wonder if it's possible.

According to the documentation available on https://developers.google.com/assistant/app, this should indeed be possible. Please see the updated ticket for more details on useful resources.

daedaevibin commented 6 months ago

Should be 100% possible as the application is available in the Google playstore.

Go-rom commented 6 months ago

Hi,

would it imply to include non-free dependencies ? If yes then it would trigger a red flag from F-Droid.

ThrosturX commented 6 months ago

Hi,

would it imply to include non-free dependencies ? If yes then it would trigger a red flag from F-Droid.

The app already depends on Spotify, which is non-free: Screenshot_20231225_230340_F-Droid

There isn't really an added dependency other than an additional optional feature making use of the assistant if it is already enabled on the device, unless I'm misunderstanding something.

Go-rom commented 4 months ago

Hello @ThrosturX

well it's another case, it's because Spotube relies on Spotify API to access account login and music database, that's why F-Droid flags it with an anti-feature warning. Using API doesn't mean including closed-source code.

I asked this question because i really don't know and i'm interested to get this answer.