KSHSK / WAVED

Web App for Visualizing Environmental Data
Other
5 stars 1 forks source link

toastr file can't be found #263

Closed seanblue closed 10 years ago

seanblue commented 10 years ago

Failed to load resource: the server responded with a status of 404 (Not Found) http://localhost/WAVED/ThirdParty/toastr/toastr.min.js.map

Sometimes this file tries to load (and fails) and sometimes it looks like it doesn't even try.

@hpinkos Please address this as soon as possible.

hpinkos commented 10 years ago

@seanblue when is this happening? i can't reproduce this

hpinkos commented 10 years ago

toastr.min.js.map isn't even the file. it's toastr.min.js

seanblue commented 10 years ago

I know it's not a file, that's why the error is showing up haha. I can't reproduce it consistently, but it's happened at least 3 times, so it's definitely a problem. There's a (not so helpful) comment about it in the toastr file: //# sourceMappingURL=toastr.min.js.map But I don't see where it's trying to be loaded.

I think this might happen more if the cache is cleared.

stnguyen09 commented 10 years ago

I can confirm this is happening in master both locally and remotely...but I can't confirm whether it's causing any bad side effects.

screen shot 2014-05-13 at 12 18 51 am

stnguyen09 commented 10 years ago

The file in question: https://github.com/CodeSeven/toastr/blob/master/toastr.min.js.map

seanblue commented 10 years ago

Thanks @stnguyen09. We should just add it to the repo so the error never shows up.

Also: https://github.com/CodeSeven/toastr/issues/103

hpinkos commented 10 years ago

@seanblue @stnguyen09 Well I pushed that file to master. let me know if you still see the issue.

stnguyen09 commented 10 years ago

Confirmed fixed...though again I'm not sure what exactly it fixes.

seanblue commented 10 years ago

Apparently this file is there to allow debugging with the minified file. It doesn't seem to actually do that here, but it's a cool idea.