search

KSHSK / WAVED

Web App for Visualizing Environmental Data
Other
5 stars 1 forks source link

Simple glyph actions (DO NOT MERGE) #270

Closed seanblue closed 10 years ago

seanblue commented 10 years ago

This pull request is just for @stnguyen09 to see the diff. If it's good, he will merge it into his branch at some point.

stnguyen09 commented 10 years ago

@seanblue How the heck does this work? There's no ListPropertyDisplayTemplate so where are you editing the glyph actions from?

seanblue commented 10 years ago

You're not creating actions on the glyph list, but on individual glyph VMs. So this PR just asks WidgetVM and subclasses to return a list of other VMs to add for actions. Specifically, USMapVM returns the list of GlyphVMs.

On May 24, 2014, at 3:43 PM, stnguyen09 notifications@github.com wrote:

@seanblue How the heck does this work? There's no ListPropertyDisplayTemplate so where are you editing the glyph actions from?

— Reply to this email directly or view it on GitHub.

stnguyen09 commented 10 years ago

Oh…that makes a heck of a lot more sense. Thanks.

Steve Nguyen Drexel University - Computer Science st.nguyen09@gmail.com (484) 602-5138

On Saturday, May 24, 2014 at 3:50 PM, seanblue wrote:

You're not creating actions on the glyph list, but on individual glyph VMs. So this PR just asks WidgetVM and subclasses to return a list of other VMs to add for actions. Specifically, USMapVM returns the list of GlyphVMs.

On May 24, 2014, at 3:43 PM, stnguyen09 <notifications@github.com (mailto:notifications@github.com)> wrote:

@seanblue How the heck does this work? There's no ListPropertyDisplayTemplate so where are you editing the glyph actions from?

—
Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub (https://github.com/KSHSK/WAVED/pull/270#issuecomment-44098070).

seanblue commented 10 years ago

@stnguyen09 If you're done with this you can close it.