search

KSHSK / WAVED

Web App for Visualizing Environmental Data
Other
5 stars 1 forks source link

Undo doesn't clear error message #287

Closed seanblue closed 10 years ago

seanblue commented 10 years ago

Steps:

  1. Open Properties Panel for any component that has a property with validation.
  2. Make a valid change (history added)
  3. Make an invalid change (error message shows up)
  4. Click undo.

This undoes the change, but the error message is still visible. It should go away since any undo will always make the value valid.

stnguyen09 commented 10 years ago

Off the top of my head, this is probably due to the change being made directly to the attribute rather than going through the setter (where the validation and error flag setting occurs).