search

KSHSK / WAVED

Web App for Visualizing Environmental Data
Other
5 stars 1 forks source link

Help dialog and bug fixes #300

Closed seanblue closed 10 years ago

seanblue commented 10 years ago

Covers #283, #274, and #293.

seanblue commented 10 years ago

@stnguyen09 @KeithJH @kristiancalhoun @hpinkos This should be a quick PR if you some time.

stnguyen09 commented 10 years ago

In the middle of a review right now

Steve Nguyen Drexel University - Computer Science st.nguyen09@gmail.com (484) 602-5138

On Tuesday, June 10, 2014 at 9:21 PM, seanblue wrote:

@stnguyen09 (https://github.com/stnguyen09) @KeithJH (https://github.com/KeithJH) @kristiancalhoun (https://github.com/kristiancalhoun) @hpinkos (https://github.com/hpinkos) This should be a quick PR if you some time.

— Reply to this email directly or view it on GitHub (https://github.com/KSHSK/WAVED/pull/300#issuecomment-45691966).

stnguyen09 commented 10 years ago

Code and functionality look fine besides that one comment about case-insensitivity.

seanblue commented 10 years ago

@stnguyen09 So it looks like using the abbreviation is causing issues. Any state that uses the abbreviation can't display the state name with an action. https://www.cs.drexel.edu/~kjh65/WAVED/help/?project=sean

seanblue commented 10 years ago

@stnguyen09 Should be good now.

stnguyen09 commented 10 years ago

@seanblue I was just gonna ask whether the abbreviation was added to the triggers. You beat me to it.

seanblue commented 10 years ago

@stnguyen09 And that reminded me to add the abbreviation to the help message.

seanblue commented 10 years ago

@stnguyen09 This small change shouldn't need a second review, right?

stnguyen09 commented 10 years ago

Nah, I'll merge it before I go to bed.