search

KSHSK / WAVED

Web App for Visualizing Environmental Data
Other
5 stars 1 forks source link

Export glyph #302

Closed hpinkos closed 10 years ago

hpinkos commented 10 years ago

This should about to it.
I'm not sure what the deal is with data, but I remember someone saying it's not in yet anyway.

seanblue commented 10 years ago

Any hooking up with data Kristian will have to do for USMap anyway, so he can just do both together.

Is this functional or skeleton?

On Jun 13, 2014, at 12:46 AM, hpinkos notifications@github.com wrote:

This should about to it.

I'm not sure what the deal is with data, but I remember someone saying it's not in yet anyway.

You can merge this Pull Request by running

git pull https://github.com/KSHSK/WAVED export-glyph Or view, comment on, or merge it at:

https://github.com/KSHSK/WAVED/pull/302

Commit Summary

glyphs to js File Changes

M Source/models/Widget/USMapWidget/USMap.js (60) Patch Links:

https://github.com/KSHSK/WAVED/pull/302.patch https://github.com/KSHSK/WAVED/pull/302.diff — Reply to this email directly or view it on GitHub.

seanblue commented 10 years ago

Data is being exported by the way. Widgets/glyphs just aren't set to rerender when data is changed by an action. So you should be able to export working glyphs, just not with those parts tied together.

On Jun 13, 2014, at 12:46 AM, hpinkos notifications@github.com wrote:

This should about to it.

I'm not sure what the deal is with data, but I remember someone saying it's not in yet anyway.

You can merge this Pull Request by running

git pull https://github.com/KSHSK/WAVED export-glyph Or view, comment on, or merge it at:

https://github.com/KSHSK/WAVED/pull/302

Commit Summary

glyphs to js File Changes

M Source/models/Widget/USMapWidget/USMap.js (60) Patch Links:

https://github.com/KSHSK/WAVED/pull/302.patch https://github.com/KSHSK/WAVED/pull/302.diff — Reply to this email directly or view it on GitHub.

hpinkos commented 10 years ago

okay, i'll change the data tomorrow morning. this theoretically should be functional, but i didn't test it. i'll try to test it when i'm changing the data part tomorrow.

seanblue commented 10 years ago

@hpinkos @kristiancalhoun You should pull out the stuff for rendering glyphs into a function so that it can be rerendered easily.

kristiancalhoun commented 10 years ago

@seanblue @KeithJH @stnguyen09 @hpinkos I cleaned this up a bit/hooked it up to Keith's exported data sets. Can someone review and test it for functionality/multiple glyphs sets, etc.?

kristiancalhoun commented 10 years ago

FYI, right now this only works for static sets of glyphs.

seanblue commented 10 years ago

Does a map properly export now? How do you mean things are hooked up to datasets? Is the on change stuff hooked up?

Please give an overview for what is left to test and what is not done at all. I should be able to test on Sunday or Monday.

If you haven't yet, make the export ID change (the hyphen/space replace one) so that it works properly.

On Jul 5, 2014, at 12:44 AM, Kristian Calhoun notifications@github.com wrote:

FYI, right now this only works for static sets of glyphs.

— Reply to this email directly or view it on GitHub.

seanblue commented 10 years ago

@kristiancalhoun I can confirm that both constant and scaled glyphs export properly. The exported code looks good too.

I can also confirm that glyphs work with data subsets and multiple sets of glyphs work together.

seanblue commented 10 years ago

@kristiancalhoun After those minor changes are made this will be ready to merge into the main export PR.

seanblue commented 10 years ago

@kristiancalhoun Oh, one more thing. You probably need to allow the glyph drawing code to be in a function so that it can be called to update glyphs by actions. That may need to be done here or in the actions branch, so coordinate with @stnguyen09 to decide who wants to do it.

stnguyen09 commented 10 years ago

@kristiancalhoun @seanblue I've made a generic function that draws the glyphs in my branch. See here https://github.com/KSHSK/WAVED/commit/3dfc1c4d0d0d0457f6cf5e286e88a8aa2894b48f

It probably (most definitely) still needs more tweaking, but that will come along later when actions start to actually come together and I find that the function I wrote there isn't enough.