KSP-CKAN / CKAN

The Comprehensive Kerbal Archive Network
https://forum.kerbalspaceprogram.com/index.php?/topic/197082-*
Other
1.98k stars 347 forks source link

x_netkan_force_epoch is a thing, and doesn't work #1030

Closed netkan-bot closed 9 years ago

netkan-bot commented 9 years ago

Issue by Dazpoet Wednesday May 27, 2015 at 12:39 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT Originally opened as https://github.com/KSP-CKAN/CKAN-netkan/issues/61


60 is all kinds of awesome and made us able to inject epochs into .netkan files, YAY!

There appears this was however already, partly, implemented with the non-functional x_netkan_force_epoch which generates weird versions like 1:CKAN.NetKAN.KSVersion when using the following example .netkan file

{
    "identifier": "AmpYearPowerManager",
    "x_via": "Automated KerbalStuff CKAN submission",
    "spec_version": "v1.4",
    "$kref": "#/ckan/kerbalstuff/630",
    "license": "GPL-3.0",
    "x_netkan_force_epoch"  :   "1",
    "install": [
        { "find": "REPOSoftTech", "install_to": "GameData" }
    ]
}

I think the relevant code is here and here but since I don't do code I'm not sure how these things work. Can one just delete it and resolve the issue?

pjf commented 9 years ago

Does this work now? I seem to just remember I couldn't actually type the right names in the docs/discussions. :)

Dazpoet commented 9 years ago

Afaik this does not work, nor should it work since it has been superceded by x_netkan_epoch.

pjf commented 9 years ago

Hooray! I can close this! We have x_netkan_epoch!